Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Finalize zend-servicemanager forwards-compatibility changes #96

Merged
merged 10 commits into from
Feb 18, 2016

Conversation

weierophinney
Copy link
Member

This builds off of #86 and #95, with the following changes:

  • dependency changes:
    • allow PHP 5.5+ OR PHP 7.0+
    • Use ^2.6 versions of zend-filter, zend-validator (no need to be more specific)
  • build changes:
    • run a job per servicemanager version, per PHP version (prevent regressions specific to PHP version + SM version differences)
  • incorporates feedback made during review of ServiceManager v2-v3 compatibility #95
  • ensures the InputFilterPluginManager constructor is backwards compatible with zend-servicemanager v2.

A few other minor refactors were made for consistency with other components and/or to clarify context.

Gianluca Arbezzano and others added 10 commits February 13, 2016 14:13
- to ensure no regressions between PHP versions as well.
- ensure compat with both PHP 5.5+ and 7.0+
- Use `^2.6` (no maintenance version), as we don't need to get more specific
  at this time.
- remove empty line at end of file
- Created a ternary from the original if/else, making the logic more compact.
- Added the method docblock.
- Move v2 checks into v2-specific methods of abstract factory.
- Use provided `$services` argument when lazy-instantiating filter and
  validator plugin managers.
- For abstract factory tests, vary methods tested based on service
  manager version.
- Renamed `MigrationTest` to `InputFilterPluginManagerCompatibilityTest`
  (consistency with other components, and this is specifically for
  testing migration of the plugin manager).
- Added tests to validate that the `InputFilterPluginManager` accepts no
  arguments and/or a `ConfigInterface` argument to the constructor when
  using zend-servicemanager v2.
- Updated the `InputFilterPluginManager` constructor to mirror that of
  the 2.7 and 3.0 series of zend-servicemanager; it also populates the
  initializers prior to calling the parent constructor, allowing
  overriding.
From what I can tell, it was added for purposes of testing; I updated
the test to use `assertAttributeSame`, varying the property to test
against based on SM version.
@weierophinney weierophinney added this to the 2.6.0 milestone Feb 18, 2016
@weierophinney weierophinney self-assigned this Feb 18, 2016
@weierophinney weierophinney merged commit 598e20d into zendframework:develop Feb 18, 2016
weierophinney added a commit that referenced this pull request Feb 18, 2016
weierophinney added a commit that referenced this pull request Feb 18, 2016
@weierophinney weierophinney deleted the feature/95 branch February 18, 2016 19:35
stefanotorresi added a commit to juriansluiman/Soflomo-Purifier that referenced this pull request Mar 10, 2016
zendframework/zend-inputfilter#96 introduced a signature change in
`InputFilterPluginManager::populateFactories()`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants